Changeset 131:568476db7115 for nagslang

Timestamp:

Sep 2, 2013, 3:43:45 PM (7 years ago)

Author:

Stefano Rivera <stefano@…>

Branch:

default

rebase_source:

513891382d16b7e9129c3c82f5bfa9906d4be96b

Message:

Dump inline lists and dicts too

File:

• nagslang/yamlish.py (modified) (3 diffs)

nagslang/yamlish.py

@@ -7 +7 @@
  * ints, floats,
  * True, False, and None
+dict keys can only be strings.
 '''
 
@@ -31 +32 @@
 class Dumper(object):
     def dump(self, data):
-        return '\n'.join(self._dump(data))
-
-    def _dump(self, data, indent=0):
+        return '\n'.join(self._dump_block(data))
+
+    def _dump_block(self, data, indent=0):
+        for type_ in (list, dict):
+            if isinstance(data, type_):
+                f = getattr(self, '_dump_%s_block' % type_.__name__)
+                return f(data, indent)
+        raise NotImplementedError()
+
+    def _dump_inline(self, data):
+        if data in (True, False, None):
+            return self._dump_literal(data)
         for type_ in (list, dict, basestring, int, float):
             if isinstance(data, type_):
                 f = getattr(self, '_dump_%s' % type_.__name__)
-                return f(data, indent)
-        if data in (True, False, None):
-            return self._dump_literal(data, indent)
+                return f(data)
         raise NotImplementedError()
 
-    def _dump_list(self, data, indent):
+    def _dump_list_block(self, data, indent):
         output = []
         for item in data:
-            dumped = self._dump(item, indent + 2)
-            dumped[0] = '%s- %s' % (' ' * indent, dumped[0][indent + 2:])
-            output += dumped
+            if self._inlineable(item):
+                output.append('%s- %s' % (' ' * indent,
+                                          self._dump_inline(item)))
+            else:
+                dumped = self._dump_block(item, indent + 2)
+                dumped[0] = '%s- %s' % (' ' * indent, dumped[0][indent + 2:])
+                output += dumped
         return output
 
-    def _dump_dict(self, data, indent):
+    def _dump_dict_block(self, data, indent):
         output = []
         for k, v in sorted(data.iteritems()):
             output.append('%s%s:' % (' ' * indent, k))
-            if isinstance(v, dict):
-                output += self._dump(v, indent + 2)
+            if self._inlineable(v):
+                output[-1] += ' ' + self._dump_inline(v)
+            elif isinstance(v, dict):
+                output += self._dump_block(v, indent + 2)
             elif isinstance(v, list):
-                output += self._dump(v, indent)
+                output += self._dump_block(v, indent)
             else:
-                value = self._dump(v)
-                assert len(value) == 1
-                output[-1] += ' %s' % value[0]
+                raise NotImplementedError()
         return output
 
-    def _dump_basestring(self, data, indent):
+    def _inlineable(self, data):
+        if isinstance(data, list):
+            return all(not isinstance(item, (list, dict)) for item in data)
+        elif isinstance(data, dict):
+            return all(not isinstance(item, (list, dict))
+                       for item in data.itervalues())
+        else:
+            return True
+
+    def _dump_list(self, data):
+        return '[%s]' % ', '.join(self._dump_inline(item) for item in data)
+
+    def _dump_dict(self, data):
+        return '{%s}' % ', '.join(
+                '%s: %s' % (self._dump_inline(key), self._dump_inline(value))
+                for key, value in data.iteritems())
+
+    def _dump_basestring(self, data):
         if data in ('true', 'false', 'null'):
-            data = "'%s'" % data
-        elif "'" in data:
-            data = "'%s'" % data.replace("'", "''")
-        elif data == '':
-            data = "''"
-        return [' ' * indent + data]
-
-    def _dump_int(self, data, indent):
-        return ['%s%i' % (' ' * indent, data)]
-
-    def _dump_float(self, data, indent):
-        return ['%s%f' % (' ' * indent, data)]
-
-    def _dump_literal(self, data, indent):
-        string = {
+            return "'%s'" % data
+        if "'" in data:
+            return "'%s'" % data.replace("'", "''")
+        if data == '':
+            return "''"
+        return data
+
+    def _dump_int(self, data):
+        return str(data)
+
+    def _dump_float(self, data):
+        return str(data)
+
+    def _dump_literal(self, data):
+        return {
             True: 'true',
             False: 'false',
             None: 'null',
         }[data]
-        return [' ' * indent + string]
 
 
@@ -214 +242 @@
             return output
         if value.startswith('!!'):
-            raise NotImplemented()
+            raise NotImplementedError()
         if value == 'true':
             return True